-
Notifications
You must be signed in to change notification settings - Fork 470
Sebastian/vf tui search 2026 01 #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| elif event.key == "down": | ||
| self._move_selection(1) | ||
| event.prevent_default() | ||
| event.stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrow keys interfere with search Input cursor navigation
Medium Severity
The on_key handler in SearchScreen unconditionally intercepts all arrow key events at the screen level without checking which widget has focus. Since the Input widget is focused on mount (line 1068), pressing left/right arrow keys to navigate within the search query text also triggers _switch_column(), causing the active result column to change unexpectedly. This makes it difficult for users to edit their search pattern using arrow keys because the UI responds to those keys in ways the user doesn't intend. The handler needs to check if the Input has focus before intercepting arrow keys for column/selection navigation.
🔬 Verification Test
Why verification test was not possible: This is a TUI (Textual Terminal User Interface) application that requires an interactive terminal environment to test. The bug involves keyboard event handling during user interaction, which cannot be easily unit tested without mocking the entire Textual event system and terminal environment. The bug is evident from code inspection: on_key unconditionally intercepts arrow keys at the screen level while the Input widget is focused by default on mount, causing unintended side effects when users try to navigate within their search text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended behavior. This is mostly mean for quick searches, so if there's a mistake, hit the back-key and type again. This override allows for quick and intuitive result selection with the arrow keys.
Description
Added two new features:
s)vf-tui-2026-01-08.mov
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Adds in-run search and richer run selection details to the Textual TUI.
s) inViewRunScreen; displays results in a modal, highlights matches inprompt/completion, auto-scrolls to the selected line, and clears highlight after a short delaySelectRunScreenshowing metadata like avg reward, metrics, runtime,env_args, andsampling_args; updates as runs are highlightedWritten by Cursor Bugbot for commit 9f45f1c. This will update automatically on new commits. Configure here.