Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously we would redundantly save the results in
generateandrun_evaluation(just once also pushing to HF hub). this makes it so that generate is entirely responsible for the saving and pushing to hub to avid unnecessary redundant disk writes.Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Fixes redundant saving of evaluation results.
save_rollout_resultscall inrun_evaluationso results are saved only byvf_env.evaluatewhensave_resultsis enabledWritten by Cursor Bugbot for commit cc3af89. This will update automatically on new commits. Configure here.