Skip to content

fix double save results in vf-eval#771

Merged
willccbb merged 2 commits intomainfrom
fix-double-save
Jan 23, 2026
Merged

fix double save results in vf-eval#771
willccbb merged 2 commits intomainfrom
fix-double-save

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Jan 23, 2026

Description

previously we would redundantly save the results in generate and run_evaluation (just once also pushing to HF hub). this makes it so that generate is entirely responsible for the saving and pushing to hub to avid unnecessary redundant disk writes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Fixes redundant saving of evaluation results.

  • Removes the post-evaluation save_rollout_results call in run_evaluation so results are saved only by vf_env.evaluate when save_results is enabled
  • No changes to evaluation flow, callbacks, or output formatting

Written by Cursor Bugbot for commit cc3af89. This will update automatically on new commits. Configure here.

@mikasenghaas mikasenghaas marked this pull request as ready for review January 23, 2026 10:25
@mikasenghaas mikasenghaas requested a review from willccbb January 23, 2026 10:26
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@willccbb willccbb merged commit 4b90453 into main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants