Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously, we used
EvalConfigto determine the valid fields in CLI but this is (a) confusing UX and (b) leads to some fields being ignored (e.g. all ofclient_config) because the resolution logic to build the eval expects the CLI syntax. for example:Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Bug fix: align TOML validation with CLI args
valid_fieldsderived fromEvalConfigwith an explicit set mirroring CLI flags (env, model/client, sampling, evaluation, logging, saving) inload_toml_config[[eval]]validation now checks against these CLI-aligned fields, reducing false rejections and ignored fields during config resolutionWritten by Cursor Bugbot for commit 200e08f. This will update automatically on new commits. Configure here.