Skip to content

mirror cli args in toml config#773

Merged
willccbb merged 1 commit intomainfrom
resolve-client-config
Jan 23, 2026
Merged

mirror cli args in toml config#773
willccbb merged 1 commit intomainfrom
resolve-client-config

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Jan 23, 2026

Description

previously, we used EvalConfig to determine the valid fields in CLI but this is (a) confusing UX and (b) leads to some fields being ignored (e.g. all of client_config) because the resolution logic to build the eval expects the CLI syntax. for example:

  • if you try api_key_var = "MY_KEY" → rejected by validation as "invalid field"0
  • if you try client_config.api_key_var → validation might pass but build_eval_config won't find it

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Bug fix: align TOML validation with CLI args

  • Replace valid_fields derived from EvalConfig with an explicit set mirroring CLI flags (env, model/client, sampling, evaluation, logging, saving) in load_toml_config
  • Global and per-[[eval]] validation now checks against these CLI-aligned fields, reducing false rejections and ignored fields during config resolution

Written by Cursor Bugbot for commit 200e08f. This will update automatically on new commits. Configure here.

@mikasenghaas mikasenghaas requested a review from willccbb January 23, 2026 11:17
@mikasenghaas mikasenghaas marked this pull request as ready for review January 23, 2026 11:19
@willccbb willccbb merged commit a362d76 into main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants