return last result if retries exhausted#782
Merged
mikasenghaas merged 3 commits intomainfrom Jan 25, 2026
Merged
Conversation
willccbb
approved these changes
Jan 24, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously, when retries are exhausted, we raise and crash an eval run. now we return the final state (with the last error in the state), mirroring the behavior when not setting retries
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Implements non-crashing retry exhaustion behavior and aligns tests.
verifiers/utils/async_utils.pymaybe_retryto storelast_resultand usetenacity'sretry_error_callbackto return it when retries are exhausted; add error-level log and keep raising only for configured error types during retriesSimpleEnvironment.rolloutintry/except vf.Errorto record errors instateinstead of raisingtests/test_environment.py:statestaterather than raisingWritten by Cursor Bugbot for commit 34040ee. This will update automatically on new commits. Configure here.