Skip to content

warning log in RLTrainer#783

Merged
willccbb merged 2 commits intomainfrom
will/trainer-warning
Jan 25, 2026
Merged

warning log in RLTrainer#783
willccbb merged 2 commits intomainfrom
will/trainer-warning

Conversation

@willccbb
Copy link
Member

@willccbb willccbb commented Jan 25, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Clarifies usage of vf.RLTrainer and nudges toward prime-rl.

  • Adds a logger.warning in RLTrainer.__init__ stating it is for educational/demo purposes only and linking to prime-rl
  • Updates docs/training.md to include the same note under the vf.RLTrainer section
  • Adds a clarifying inline comment in MultiTurnEnv.rollout about @vf.stop/@vf.cleanup behavior

Written by Cursor Bugbot for commit f2326a6. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@willccbb willccbb merged commit 31a1067 into main Jan 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant