Codex-generated pull request#889
Merged
willccbb merged 2 commits intoeli/anthropic-clientfrom Feb 11, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The function had no remaining callers after its call sites in state_to_output were removed. Delete the unused definition. Co-authored-by: will brown <willccbb@users.noreply.github.com>
|
|
mikasenghaas
added a commit
that referenced
this pull request
Feb 14, 2026
* feat(clients): introduce unified client interface and provider adapters * refactor(environment): migrate rollout core to Response + tool_defs * refactor(envs): align tool/multiturn/integrations with new message and tool flow * refactor(eval): unify eval outputs/serialization and improve display plumbing * test(migration): update env/tool trajectory tests for unified client/types * test(envs): harden env smoke tests and fixture setup for clean installs * chore(endpoints): annotate endpoint registry with explicit client types * dont strip client types * small reversions * format checks * cleaner handling of pure completions with custom types * formatting * patch single turn to convert message list back to raw string * safe serialization, output has both oai_tools and tool_defs * test needs to accept kwargs * update tests with tool_defs * rename convert_func_to_tool_def * formatting * fix lines in types * harden tool_defs/oai_tools to error when oai tools are passed in * harden downstream reading of tool_defs * use vf.client * much tighter use of custom types * get rid of legacy response.choices * patch test * clean up into unified normalized_messages util function * bugbot fixes * cli tool normalization * more cli stuff * add text message to client message types * bugbot, normalize no tool calls across clients * reasoning first * ty check * fix anthropic tool call blocks * cli agent intercept back to openai types * usage in anthropic types * normalize raw tool calls oai tools * cleaner errors * revert to error string matches and pass through interleaved thinking to anthropic client * small prepend system prompt edit * small formatting * max completion tokens rename * anthropic overlong error * bugbot shallow copy * Codex-generated pull request (#889) Co-authored-by: will brown <willccbb@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> * flatten back into a string at the end for completions * preserve thinking block anthropic content: * remove interleaved from eval config * minor * each client in its own file * move some stuff around * rename to content_to_text * do not warn on pydantic serialization on env worker * client everywhere * fix ty * fix endpoints * pop unrecognized stop arg * add deepseek reasoner * remove interleaved thinking from env * fix tests with claude * rename to mock_client * update docs * updated more reasoning content fields * do not make interleaved settable on client * simplify * make thinking block part of our ass msg type * fix endpoints * rename to oai_tools * allow closing clients * removed unused native client * add docs * conditional warn * only add reasoning content if its a string --------- Co-authored-by: eligotts <78387377+eligotts@users.noreply.github.com> Co-authored-by: will brown <williambrown97@gmail.com> Co-authored-by: will brown <willccbb@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task
Note
Medium Risk
Behavioral changes to saved results format (completion now always serialized as message lists and
oai_toolsremoved) may break downstream consumers expecting flattened strings or legacy fields.Overview
Standardizes endpoint configuration by replacing
client_typewithapi_client_type(andtypeas a shorthand in registries), renaming the CLI flag to--api-client-type, and updating endpoint registry parsing to reject the deprecatedclient_typefield and catch conflicting type declarations.Changes rollout/output serialization to keep
prompt/completionasMessagesconsistently (includingmessage_type="completion"), updatingTrajectoryStep/RolloutOutput/Statetyping and tests accordingly; this also removes the backward-compatoai_toolsalias and stops flattening completion text into strings.Written by Cursor Bugbot for commit 34f4c38. This will update automatically on new commits. Configure here.