Merged
Conversation
- add JsonFormatter and json_logging param to setup_logging() - thread json_logging through EnvServer.__init__ - when json_logging=True, also configure root logger with JSON formatter so environment code using logging.getLogger(__name__) emits JSON
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4823015e6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
mikasenghaas
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonFormatterandjson_loggingparam tosetup_logging()json_loggingthroughEnvServer.__init__json_logging=True, configure root logger with JSON formatter so environment code usinglogging.getLogger(__name__)also emits JSONNote
Medium Risk
Touches global logging configuration (including the root logger), which can change log output/handlers and affect integrations that rely on existing formatting.
Overview
Adds optional structured JSON logging via a new
JsonFormatterand ajson_loggingflag onsetup_logging().When enabled,
setup_logging()also configures the root logger with the JSON formatter so third-party/environment code using standardlogging.getLogger(__name__)emits JSON as well.EnvServer.__init__now accepts and forwardsjson_loggingto logging setup.Written by Cursor Bugbot for commit dfa95c8. This will update automatically on new commits. Configure here.