Skip to content

Issue 966 - Template jacobian_matrix and element_types with dimension.#1007

Merged
icui merged 17 commits intodevelfrom
issue-966
Jul 11, 2025
Merged

Issue 966 - Template jacobian_matrix and element_types with dimension.#1007
icui merged 17 commits intodevelfrom
issue-966

Conversation

@icui
Copy link
Collaborator

@icui icui commented Jul 11, 2025

Description

  • Template assembly::element_types with dimension.
  • Template assembly::jacobian_matrix with dimension.
  • Update boundary parameter to reference value.

Issue Number

Closes #965 and #966

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui icui requested review from Rohit-Kakodkar and lsawade July 11, 2025 13:11
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed

@lsawade
Copy link
Collaborator

lsawade commented Jul 11, 2025

@Rohit-Kakodkar this good to go?

@icui icui merged commit ea270e5 into devel Jul 11, 2025
6 checks passed
@icui icui deleted the issue-966 branch July 11, 2025 18:00
@icui icui added the enhancement New feature or request label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants