ST-585: update positioning#3
Merged
ragingdave merged 70 commits intolegacy-rails-rubyfrom Sep 4, 2025
Merged
Conversation
...and to scope locking or in the worst case record locking where a scope doesn't exist.
Fix 0.3.0 release date
When using an ordering default scope in the model, the query generated by the
healer with `model.select(*positioning_columns).distinct` is invalid:
ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select
list (PG::InvalidColumnReference)
With a default scope that orders the records, Rails automatically adds the
default scope to all queries, including the SELECT DISTINCT above. This breaks
the healer, because it does not add the default ordering scope to the select
list. Unscoping the query before selecting removes the default query and makes
the healer work. This should not impact other functionality, since any ordering
required when healing must be passed explicitely anyway.
Fix healer when model uses an ordering default scope
Fix optional scope healing
…tions Document Limitations around STI and Abstract Classes
Corrects the logic in solidify_position to ensure an error is properly raised when an invalid string position is provided, improving robustness and input validation.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
jpmsantana
approved these changes
Aug 29, 2025
ragingdave
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.