Rename public methods to remove "_" prefix. And fix typo in method name. #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the methods are in the public API, so the renames should be safe. Also fix some minor type errors. I didn't feel confident writing a docstring for fix_dtypes(), so I applied noqa.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on improving the public API by renaming several methods to remove the leading underscore, which is a great step towards better code clarity. It also includes a typo fix in a method name and some improvements to type hints and docstrings. The changes are generally positive and enhance the codebase's maintainability. I've identified a couple of areas where further improvements can be made, particularly regarding a latent bug exposed by a type hint change and an opportunity to restore a useful type annotation.
LeoGrin
approved these changes
Sep 1, 2025
oscarkey
added a commit
that referenced
this pull request
Nov 12, 2025
…x typo in method name. (#128) * Record copied public PR 476 * Rename public methods to remove "_" prefix. And fix typo in method name. (#476) None of the methods are in the public API, so the renames should be safe. Also fix some minor type errors. I didn't feel confident writing a docstring for fix_dtypes(), so I applied noqa. (cherry picked from commit 7ab65f8) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the methods are in the public API, so the renames should be safe.
Also fix some minor type errors.
I didn't feel confident writing a docstring for fix_dtypes(), so I applied noqa.