Forward cache_trainset_representation to load_model. #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows to load models that don't support caching yet and works for models that might assign this to a different attribute (previously we set to cache_trainset_representation=True when loading, just to overwrite the attribute immediately after).
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how the cache_trainset_representation setting is handled when loading a model. The change involves passing this setting as a parameter through the load_model function, instead of setting it as an attribute on the model object after it has been loaded. This is a significant improvement as it makes the model loading process more robust and flexible, especially for models that might not support caching or use a different internal attribute for it. The implementation is clean, well-documented, and correctly propagates the parameter down to the architecture factory function. The changes look solid and improve the overall design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows to load models that don't support caching yet and works for models that might assign this to a different attribute (previously we set to cache_trainset_representation=True when loading, just to overwrite the attribute immediately after).