Add global seed fixture for reproducible tests #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines a session-scoped fixture in conftest.py that sets seeds for torch, numpy, and random to ensure deterministic test behavior across sessions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a global pytest fixture to set random seeds for torch, numpy, and random, aiming to improve test reproducibility. The implementation is sound and correctly uses a session-scoped, autouse fixture. My feedback includes suggestions to further enhance determinism for CUDA operations, add a docstring for clarity, and improve comments within the fixture.
noahho
approved these changes
Sep 19, 2025
oscarkey
requested changes
Sep 19, 2025
Contributor
oscarkey
left a comment
oscarkey
left a comment
There was a problem hiding this comment.
This seems like a good idea to me! Thank you. Just a few small suggestions.
- removed unnecessary comment - fixture scope = "function" - return type - removed unnecessary torch.cuda.manual_seed_all call
oscarkey
approved these changes
Sep 30, 2025
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Record copied public PR 516 * Add global seed fixture for reproducible tests (#516) Co-authored-by: MagnumMandel <111045718+PufferFishCode@users.noreply.github.com> Co-authored-by: noahho <Noah.homa@gmail.com> --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: MagnusBuehler <111045718+MagnusBuehler@users.noreply.github.com> Co-authored-by: MagnumMandel <111045718+PufferFishCode@users.noreply.github.com> Co-authored-by: noahho <Noah.homa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a session-scoped fixture in conftest.py that sets seeds for torch, numpy, and random to ensure deterministic test behavior across sessions.
Motivation and Context
Multiple tests rely on randomly sampled data using random, numpy, and torch. Without a fixed seed, this can lead to non-deterministic and flaky test results. Adding a global seed fixture improves consistent and reproducible test behavior across runs.
Public API Changes
How Has This Been Tested?
On a local machine the randomly sampled data across test runs are consistent.
Checklist
CHANGELOG.md(if relevant for users).