[Resolved Merge Conflicts from PR 312] Remove shell download script and fix fallback URLs #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the model download logic to include fallback URLs, which is a great improvement for robustness. The changes in src/tabpfn/model_loading.py correctly implement a sequence of download attempts from HuggingFace and a fallback S3 source. The new test in tests/test_download_fallbacks.py effectively verifies this fallback mechanism.
My main feedback is on improving the error handling within the config.json download logic to avoid silent failures and provide more informative log messages, which will make debugging easier.
Overall, the changes are well-implemented and the addition of tests is appreciated.
noahho
reviewed
Sep 19, 2025
noahho
approved these changes
Oct 1, 2025
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
…l download script and fix fallback URLs (#168) * Record copied public PR 520 * [Resolved Merge Conflicts from PR 312] Remove shell download script and fix fallback URLs (#520) Co-authored-by: noahho <noah@priorlabs.ai> (cherry picked from commit c078f9d) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: MagnusBuehler <111045718+MagnusBuehler@users.noreply.github.com> Co-authored-by: noahho <noah@priorlabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PR 312 had merging conflicts, due to out of date main branch. I resolved these issues and merged with up-to-date main branch code.
src/tabpfn/model/loading.py(deprecated) tosrc/tabpfn/model_loading.py, and test imports accordingly. Also solved merge conflict in Readme.mdPublic API Changes
How Has This Been Tested?
locally with Mock test and verified that download links work.
Checklist
CHANGELOG.md(if relevant for users).