Re-enable onnx tests. #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables ONNX export tests for Python 3.13, reflecting that onnx now supports this version. The changes correctly remove the pytest.xfail condition for Python 3.13 from the ONNX tests in both test_classifier_interface.py and test_regressor_interface.py. As a good housekeeping measure, the now-unused sys imports are also removed. The changes are focused and correct.
brendan-priorlabs
approved these changes
Sep 23, 2025
Contributor
brendan-priorlabs
left a comment
brendan-priorlabs
left a comment
There was a problem hiding this comment.
LGTM. Left a cleanup comment, but you guys are obviously slammed right now, so feel free to ignore/TODO
Onnx now works on Python 3.13.
oscarkey
force-pushed
the
ok-onnx-tests
branch
from
2adfa79 to
f98dd7a
Compare
oscarkey
added a commit
that referenced
this pull request
Nov 12, 2025
* Record copied public PR 526 * Re-enable onnx tests. (#526) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onnx now works on Python 3.13.