Skip to content

Conversation

@oscarkey
Copy link
Contributor

  • Run ruff format and ruff check --fix
  • New rule PLC0415 requires imports to be at the top level: move some imports and add noqa to others.
  • Move ignores of two entire files (which are copied without changes from other repositories) to the pyproject.toml

- Run `ruff format` and `ruff check --fix`
- New rule PLC0415 requires imports to be at the top level: move some
  imports and add noqa to others.
- Move ignores of two entire files (which are copied without changes
  from other repositories) to the pyproject.toml
@oscarkey oscarkey requested a review from priorphil October 14, 2025 13:31
@oscarkey oscarkey requested a review from a team as a code owner October 14, 2025 13:31
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Ruff to version 0.14 and applies the corresponding formatting and linting fixes. The changes are mostly stylistic, such as reformatting assert statements and type hints, and moving imports to the top level to comply with the new PLC0415 rule. Where local imports are necessary (e.g., for optional dependencies or to avoid circular imports), noqa directives have been correctly added with explanatory comments. The PR also improves code quality by marking unused variables and centralizing file-level ignores in pyproject.toml. The changes are consistent and well-executed, improving the overall code hygiene. I have no further suggestions.

@oscarkey oscarkey removed the request for review from a team October 14, 2025 13:36
Copy link
Collaborator

@LeoGrin LeoGrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

oscarkey and others added 3 commits October 14, 2025 15:42
Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
@oscarkey oscarkey merged commit 9e7a4a2 into main Oct 14, 2025
10 checks passed
@oscarkey oscarkey deleted the ok-ruff-upgrade branch October 14, 2025 14:43
oscarkey added a commit that referenced this pull request Nov 12, 2025
* Record copied public PR 549

* Update Ruff to 0.14. (#549)

Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>

---------

Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants