-
Notifications
You must be signed in to change notification settings - Fork 538
Update Ruff to 0.14. #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ruff to 0.14. #549
Conversation
- Run `ruff format` and `ruff check --fix` - New rule PLC0415 requires imports to be at the top level: move some imports and add noqa to others. - Move ignores of two entire files (which are copied without changes from other repositories) to the pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Ruff to version 0.14 and applies the corresponding formatting and linting fixes. The changes are mostly stylistic, such as reformatting assert statements and type hints, and moving imports to the top level to comply with the new PLC0415 rule. Where local imports are necessary (e.g., for optional dependencies or to avoid circular imports), noqa directives have been correctly added with explanatory comments. The PR also improves code quality by marking unused variables and centralizing file-level ignores in pyproject.toml. The changes are consistent and well-executed, improving the overall code hygiene. I have no further suggestions.
LeoGrin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
* Record copied public PR 549 * Update Ruff to 0.14. (#549) Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com> --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai> Co-authored-by: LeoGrin <45738728+LeoGrin@users.noreply.github.com>
ruff formatandruff check --fix