Skip to content

Check for incompatible licenses #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
noahho merged 29 commits into from
Oct 27, 2025
Merged

Check for incompatible licenses #561

noahho merged 29 commits into from
Oct 27, 2025

Conversation

@brendan-priorlabs
Copy link
Contributor

@brendan-priorlabs brendan-priorlabs commented Oct 22, 2025

ref ENG-229

@brendan-priorlabs brendan-priorlabs requested a review from a team as a code owner October 22, 2025 16:55
@brendan-priorlabs brendan-priorlabs requested review from oscarkey and removed request for a team October 22, 2025 16:55
@brendan-priorlabs brendan-priorlabs changed the title Check for incompatible licenses WIP Check for incompatible licenses Oct 22, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the pyproject.toml file to include licensecheck in the ci dependencies. I have identified a potential issue with the version specified for licensecheck and suggest updating it to a more reasonable version.

@brendan-priorlabs brendan-priorlabs changed the title WIP Check for incompatible licenses Check for incompatible licenses Oct 23, 2025
brendan-priorlabs
brendan-priorlabs commented Oct 23, 2025
View reviewed changes
oscarkey
oscarkey approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@oscarkey oscarkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside form nvidia comment!

noahho
noahho reviewed Oct 24, 2025
View reviewed changes
@brendan-priorlabs
Copy link
Contributor Author

brendan-priorlabs commented Oct 24, 2025

@noahho, this should be ready for another pass

noahho
noahho approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@noahho noahho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for giving this another pass

@noahho noahho removed the request for review from simo-prior October 27, 2025 16:32
@noahho noahho merged commit c4fc6de into main Oct 27, 2025
10 checks passed
oscarkey pushed a commit that referenced this pull request Nov 12, 2025
@brendan-priorlabs @mirror-bot
[from public #561] Check for incompatible licenses (#202)
03b4fe9 
* Record copied public PR 561

* Check for incompatible licenses (#561)

(cherry picked from commit c4fc6de)

---------

Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oscarkey oscarkey oscarkey approved these changes

@noahho noahho noahho approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendan-priorlabs @oscarkey @noahho