Fix build error on Python 3.9 #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-priorlabs
requested review from
noahho
and removed request for
a team
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a build failure on Python 3.9 by pinning pyobjc-framework-Metal and its indirect dependency pyobjc-core. While the intention is correct, the specified version range is too broad and will not resolve the underlying issue. I have provided a critical suggestion to adjust the version pinning to correctly exclude the problematic versions and ensure the build succeeds on Python 3.9.
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Record copied public PR 562 * Fix build error on Python 3.9 (#562) Our mac builds with Python 3.9 were all failing because an indirect dep stopped publishing packages for 3.9. See https://github.com/PriorLabs/TabPFN/actions/runs/18689219131/job/53367028472?pr=539 This fixes it by pinning away for the old builds. (cherry picked from commit b215940) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our mac builds with Python 3.9 were all failing because an indirect dep stopped publishing packages for 3.9. See https://github.com/PriorLabs/TabPFN/actions/runs/18689219131/job/53367028472?pr=539
This fixes it by pinning away for the old builds.