Skip to content

Conversation

@oscarkey
Copy link
Contributor

Also move it from tabpfn.config to tabpfn.inference_config, to distinguish this module from all the other config modules we have.

We already refer to it as the "inference config" in the classifier/regressor interfaces, so this helps to be consistent.

This changes the public api:

  • a code searches (1, 2) show one use in tabpfn-extensions and in the tabpfn-client documentation. I will fix these
  • this could break external users, but as it's a major version upgrade, an easy fix, and probably few people are using it anyway, a quick offline discussion with Noah concluded it's okay

Also move it from `tabpfn.config` to `tabpfn.inference_config`, to
distinguish this module from all the other config modules we have.

We already refer to it as the "inference config" in the
classifier/regressor interfaces, so this helps to be consistent.
@oscarkey oscarkey requested a review from bejaeger October 29, 2025 13:30
@oscarkey oscarkey requested a review from a team as a code owner October 29, 2025 13:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors ModelInterfaceConfig to InferenceConfig and moves it to a new module tabpfn.inference_config. The changes are consistent and well-executed across the codebase. I've found a couple of minor issues: a placeholder in the changelog and an outdated docstring that should be updated to reflect the renaming.

Copy link
Contributor

@bejaeger bejaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for changing this.

@oscarkey oscarkey merged commit 3432eb2 into main Oct 29, 2025
10 checks passed
@oscarkey oscarkey deleted the ok-rename-interface-config branch October 29, 2025 13:55
oscarkey added a commit to PriorLabs/tabpfn-client that referenced this pull request Oct 30, 2025
The name of this class was changed in tabpfn in PriorLabs/TabPFN#575
oscarkey added a commit to PriorLabs/tabpfn-extensions that referenced this pull request Oct 31, 2025
ModelInterfaceConfig was renamed and moved in
PriorLabs/TabPFN#575 .
This change works with both versions.
oscarkey added a commit that referenced this pull request Nov 12, 2025
)

* Record copied public PR 575

* Rename ModelInterfaceConfig to InferenceConfig. (#575)

Also move it from `tabpfn.config` to `tabpfn.inference_config`, to distinguish this module from all the other config modules we have.

We already refer to it as the "inference config" in the classifier/regressor interfaces, so this helps to be consistent.

This changes the public api:
- code searches ([1](https://github.com/search?q=org%3APriorLabs+ModelInterfaceConfig+NOT+repo%3APriorLabs%2FTabPFN+NOT+repo%3APriorLabs%2FTabPFN-private+&type=code), [2](https://github.com/search?q=org%3APriorLabs+interface_config_+NOT+repo%3APriorLabs%2FTabPFN+NOT+repo%3APriorLabs%2FTabPFN-private+&type=code)) show one use in tabpfn-extensions and in the tabpfn-client documentation. I will fix these
- this could break external users, but as it's a major version upgrade, an easy fix, and probably few people are using it anyway, a quick offline discussion with Noah concluded it's okay

---------

Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants