-
Notifications
You must be signed in to change notification settings - Fork 538
Add kdi transform to deps. #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds kditransform as a project dependency. The change is straightforward, but I've left a comment regarding sorting dependencies for better maintainability.
Additionally, with kditransform becoming a required dependency, the fallback logic in src/tabpfn/preprocessors/kdi_transformer.py (which handles cases where kditransform is not installed) appears to be redundant. You may want to consider removing the try-except block around the import in a future pull request to simplify the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bejaeger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Hello there, I want to check the purpose of the new dependency |
|
We found that using the KDI transform for some pre-processors improves predictive performance. |
|
The conflict comes from Running on Linux: |
No description provided.