Check that inference_config is actually set when loading. #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the checkpoint is loaded and re-exported, the inference config is set, but to None.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a potential TypeError when loading a model checkpoint where inference_config is present but set to None. The change is a good safeguard. I've suggested a slightly more concise and robust way to perform this check using dict.get() and a truthiness check, which also handles cases where inference_config might be an empty dictionary.
oscarkey
approved these changes
Nov 3, 2025
Contributor
oscarkey
left a comment
oscarkey
left a comment
There was a problem hiding this comment.
ahhh nice catch! Thank you
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
…oading. (#227) * Record copied public PR 586 * Check that inference_config is actually set when loading. (#586) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> (cherry picked from commit 7fc02dd) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Phil <philipp@priorlabs.ai> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the checkpoint is loaded and re-exported, the inference config is set, but to None.
Issue
Please link the corresponding GitHub issue. If an issue does not already exist,
please open one to describe the bug or feature request before creating a pull request.
This allows us to discuss the proposal and helps avoid unnecessary work.
Motivation and Context
Public API Changes
How Has This Been Tested?
Checklist
CHANGELOG.md(if relevant for users).