Remove type restriction on REGRESSION_Y_PREPROCESS_TRANSFORMS. #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In InferenceConfig. Other values are possible, and Pydantic blocks them. There may be other types that need adjusting, but start with this one.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the restrictive Literal type from REGRESSION_Y_PREPROCESS_TRANSFORMS in InferenceConfig, replacing it with tuple[str | None, ...]. This change allows for a wider range of preprocessing transformations to be used, as defined in get_all_reshape_feature_distribution_preprocessors. The corresponding docstring has also been updated to reflect this. The change is well-motivated and correctly implemented. I have one suggestion to improve the clarity of the updated docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In InferenceConfig. Other values are possible, and Pydantic blocks them.
There may be other types that need adjusting, but start with this one.