Skip to content

Conversation

@oscarkey
Copy link
Contributor

@oscarkey oscarkey commented Nov 5, 2025

We could enable multi-gpu inference when device="auto", but I suggest we leave it off for now until a couple of fixes to improve inference speed on small datasets are in? This way the user has to explicitly turn it on, and has more of a chance of seeing if it's faster or not.

@oscarkey oscarkey requested a review from bejaeger November 5, 2025 13:29
@oscarkey oscarkey requested a review from a team as a code owner November 5, 2025 13:29
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docstrings for the device parameter in TabPFNClassifier and TabPFNRegressor to include information about multi-device inference. The changes are a good improvement, making the documentation clearer and more comprehensive.

I've suggested a minor wording change to generalize the documentation from 'GPUs' to 'devices', as the implementation seems to support parallel execution on various device types.

Additionally, I noticed that in src/tabpfn/regressor.py, the docstring for the device parameter is duplicated. The new, correct version has been added, but an old, conflicting version still exists further down in the docstring (lines 313-318). This should be removed to avoid confusion for users. Since this is outside the changed lines of this PR, I'm mentioning it here for your consideration.

Copy link
Contributor

@bejaeger bejaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@oscarkey oscarkey enabled auto-merge (squash) November 5, 2025 13:35
@oscarkey oscarkey merged commit b8bcc70 into main Nov 5, 2025
10 checks passed
oscarkey added a commit that referenced this pull request Nov 12, 2025
…inference. (#235)

* Record copied public PR 599

* Update the device doc string to include multi-gpu inference. (#599)

(cherry picked from commit b8bcc70)

---------

Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Co-authored-by: Oscar Key <oscar@priorlabs.ai>
@oscarkey oscarkey deleted the ok-device-doc branch November 12, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants