Skip to content

Add tests for V3#920

Merged
bejaeger merged 23 commits into
mainfrom
ben/make-v3-default
May 11, 2026
Merged

Add tests for V3#920
bejaeger merged 23 commits into
mainfrom
ben/make-v3-default

Conversation

@bejaeger
Copy link
Copy Markdown
Collaborator

@bejaeger bejaeger commented May 6, 2026

No description provided.

@bejaeger bejaeger requested a review from a team as a code owner May 6, 2026 16:11
@bejaeger bejaeger requested review from anuragg1209 and removed request for a team May 6, 2026 16:11
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model version to V3 and standardizes the embedding dimension variable by renaming ninp to emsize across the architecture definitions and test suites. It introduces a new embedding_dim property to the architecture interface and refactors the architecture name resolution to use explicit class instance checks. Furthermore, the PR modifies model loading and saving logic to accommodate V3 checkpoints, specifically by stripping criterion keys and including inference configurations, while temporarily disabling SVD on GPU and HuggingFace license checks. I have no feedback to provide.

@bejaeger bejaeger removed the request for review from anuragg1209 May 7, 2026 05:01
@bejaeger bejaeger requested review from oscarkey and priorphil May 7, 2026 13:14
@brendan-priorlabs
Copy link
Copy Markdown
Contributor

@bejaeger, in order to keep everything (client->server->fomo-fitting->TabPFN) compatible I have re-uploaded the checkpoints with the naming scheme used in 2.5 and 2.6. Highly suggest you cherry-pick in this commit: 92a1fd9 (We're serving off-of a branch that is essentially your PR here + that commit.)

@bejaeger bejaeger added this pull request to the merge queue May 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 11, 2026
@bejaeger bejaeger changed the title New default Add tests for V3 May 11, 2026
@bejaeger bejaeger added the no changelog needed PR does not require a changelog entry label May 11, 2026
@bejaeger bejaeger enabled auto-merge May 11, 2026 11:55
@bejaeger bejaeger added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit 98ecf33 May 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog needed PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants