Fixes Module Initialization Order#3387
Merged
brianlagunas merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This change reorders the application initialization process within
PrismAppBuilderto ensure that module types can be properly resolved and their services are registered before other application initialization delegates run.A new internal
AddModuleCatalogActionmethod and an associated collection (_moduleCatalogActions) are introduced. Module catalog configuration, where users define their application's modules, now occurs in a dedicated "Phase 1". This precedes the actual module initialization ("Phase 2"), which registers services, and finally, the general applicationOnInitializeddelegates ("Phase 3"). This guarantees that module services are available for resolution during later initialization steps.Additionally, some minor changes include:
KnownInternalParameters.NavigationModewhen navigating to aTabbedPage.CurrentPage.SoftInputModewhen replacing theWindow.Page. This workaround is no longer necessary.Bugs Fixed
API Changes
Added:
internal PrismAppBuilder AddModuleCatalogAction(Action action)Behavioral Changes
The order of execution for module catalog configuration and application
OnInitializeddelegates has changed. Modules are now configured and initialized earlier in the lifecycle, ensuring that services registered within modules are available when otherOnInitializeddelegates are invoked. This should prevent service resolution errors related to module dependencies.