Skip to content

Private data store buckets#98

Merged
brucetony merged 8 commits intomasterfrom
private-buckets
Apr 20, 2026
Merged

Private data store buckets#98
brucetony merged 8 commits intomasterfrom
private-buckets

Conversation

@brucetony
Copy link
Copy Markdown
Contributor

@brucetony brucetony commented Apr 20, 2026

Summary by CodeRabbit

  • Documentation
    • Updated admin guides for analysis execution, review, and data store management with improved terminology and clarity.
    • Revised bucket setup documentation to use credential-based private access instead of public bucket access.
    • Updated data store configuration field names from "Server/Data Path" to "Hostname/Bucket Name/Access Key/Secret Key."
    • Changed data store creation UI feedback color scheme (blue to green for success).
    • Corrected grammatical inconsistencies throughout user and deployment guides.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@brucetony has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 26 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 49 minutes and 26 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b978f223-6161-4270-84ae-aabb8008639d

📥 Commits

Reviewing files that changed from the base of the PR and between cf331d2 and 7f505ea.

📒 Files selected for processing (2)
  • src/guide/admin/bucket-setup-for-data-store.md
  • src/guide/admin/data-store-management.md
📝 Walkthrough

Walkthrough

Documentation across multiple admin and user guides updated with grammatical corrections (pluralizing "analyzes" to "analyses"), semantic adjustments to analysis execution and review workflows, and significant revisions to S3/MinIO bucket setup procedures emphasizing credential-based access with new key generation steps and updated data store field naming conventions.

Changes

Cohort / File(s) Summary
Grammar and Terminology Standardization
src/guide/admin/reviewing.md, src/guide/deployment/node-installation.md, src/guide/deployment/node-registration.md, src/guide/user/analysis-coding.md, src/guide/user/coding_examples/differential-privacy-mvp.md, src/guide/user/fhir-query.md
Corrected pluralization of "analyzes" to "analyses" throughout documentation for grammatical consistency.
Analysis Execution and Review Semantics
src/guide/admin/analysis-execution.md, src/guide/admin/analysis-review.md
Updated analysis workflow descriptions with revised approval semantics wording and removed assertion about post-completion "stopped" state behavior.
S3/MinIO Bucket Setup and Data Store Configuration
src/guide/admin/bucket-setup-for-data-store.md, src/guide/admin/data-store-management.md
Revised bucket access procedures from public to credential-based authentication; added steps for generating access/secret keys in Admin UI; updated configuration field names (Server/Data PathHostname/Bucket Name/Access Key/Secret Key); expanded Field Descriptions table with S3 and FHIR-specific fields; simplified data access management with connection testing guidance; removed "Disconnecting an Analysis" subsection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Grammar hops and bounds so true,
"Analyses" now shines in every view,
Credentials guard the S3 door,
Documentation gleams, polished to the core!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Private data store buckets' directly reflects the main change across multiple files updating bucket access configuration from public to private credential-based access.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch private-buckets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/guide/admin/analysis-review.md`:
- Line 15: Replace the misspelled word "anlaysis" with "analysis" in the
sentence that starts "Approve incoming analyses by clicking the gray triple-bar
button on the right of the anlaysis..." so the sentence reads "...on the right
of the analysis..."; update the string in the file's content (the sentence
containing "Approve incoming analyses...") to correct the typo.

In `@src/guide/admin/data-store-management.md`:
- Line 36: Fix the typo in the markdown table row inside
data-store-management.md: change "recommeded" to "recommended" in the sentence
"It is highly recommeded to keep all S3 buckets set to private" so it reads "It
is highly recommended to keep all S3 buckets set to private"; ensure no other
spelling changes are introduced.
- Line 33: There's a spelling mistake in the table cell containing "Currrently"
— update the string to "Currently" so the row reads "Type of repository in which
the data is stored. Currently, only FHIR and S3 are supported"; locate the table
row that starts with "Data Store Type" and correct that word in the markdown.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0752f645-feba-4a67-b780-ec6e9888469a

📥 Commits

Reviewing files that changed from the base of the PR and between c61043f and cf331d2.

⛔ Files ignored due to path filters (5)
  • src/public/images/minio_images/access_key_creation.png is excluded by !**/*.png
  • src/public/images/minio_images/bucket_node.png is excluded by !**/*.png
  • src/public/images/minio_images/private_bucket_access.png is excluded by !**/*.png
  • src/public/images/node_ui_images/data_store_creator.png is excluded by !**/*.png
  • src/public/images/node_ui_images/datastore_manager.png is excluded by !**/*.png
📒 Files selected for processing (10)
  • src/guide/admin/analysis-execution.md
  • src/guide/admin/analysis-review.md
  • src/guide/admin/bucket-setup-for-data-store.md
  • src/guide/admin/data-store-management.md
  • src/guide/admin/reviewing.md
  • src/guide/deployment/node-installation.md
  • src/guide/deployment/node-registration.md
  • src/guide/user/analysis-coding.md
  • src/guide/user/coding_examples/differential-privacy-mvp.md
  • src/guide/user/fhir-query.md

Comment thread src/guide/admin/analysis-review.md
Comment thread src/guide/admin/data-store-management.md Outdated
Comment thread src/guide/admin/data-store-management.md Outdated
@brucetony brucetony merged commit 2903052 into master Apr 20, 2026
1 check passed
@brucetony brucetony deleted the private-buckets branch April 20, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant