Skip to content

feat: implement features for the new hub#19

Merged
Nightknight3000 merged 5 commits intomainfrom
new_hub
Mar 18, 2026
Merged

feat: implement features for the new hub#19
Nightknight3000 merged 5 commits intomainfrom
new_hub

Conversation

@Nightknight3000
Copy link
Member

@Nightknight3000 Nightknight3000 commented Mar 18, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Corrected API endpoint path construction for storage write operations when using local data providers, improving request reliability.
    • Enabled progress tracking in streamed logs to provide real-time visibility into operation progress and completion status.

Nightknight3000 and others added 5 commits March 3, 2026 13:16
Co-authored-by: antidodo <albin2993@gmail.com>
Co-authored-by: antidodo <albin2993@gmail.com>
Co-authored-by: antidodo <albin2993@gmail.com>
Co-authored-by: antidodo <albin2993@gmail.com>
# Conflicts:
#	poetry.lock
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fbe7069f-b968-48c1-8ddb-ffd0a5ff543c

📥 Commits

Reviewing files that changed from the base of the PR and between 59699d4 and 5ff6530.

📒 Files selected for processing (2)
  • flamesdk/resources/client_apis/clients/po_client.py
  • flamesdk/resources/client_apis/clients/storage_client.py

📝 Walkthrough

Walkthrough

Two client API files were modified with minor payload and path construction updates. The PO client now includes the progress field in stream_logs payloads. The storage client adjusted request path construction by removing a trailing slash and modifying local DP path appending.

Changes

Cohort / File(s) Summary
PO Client Progress Field
flamesdk/resources/client_apis/clients/po_client.py
Uncommented and enabled the progress field in the stream_logs payload to include it in the POST body.
Storage Client Path Construction
flamesdk/resources/client_apis/clients/storage_client.py
Updated request_path in push_result: changed base path from /{type}/ to /{type} and modified local DP appending from localdp to /localdp.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Progress fields now shine so bright,
Paths adjusted left and right,
No trailing slashes in the way,
Small tweaks to make the APIs play! 🌟

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive language that doesn't convey the specific changes made in the PR. Revise the title to be more specific about the actual changes, such as 'fix: include progress field in stream_logs and correct request paths in storage_client'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new_hub
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

@Nightknight3000 Nightknight3000 merged commit f0f9c60 into main Mar 18, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant