Merged
Conversation
Also do pretty eliot log rendering and narrow the config types a bit (since they were letting through a lot of garbage before).
The exception prevents the read from succeeding and is never logged :( Also we were checking for the wrong type before, oops.
Otherwise there's a race condition in the tests and they might fail with a spending error (due to having no zkaps to spend)
So add some post-operation polling. :/
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 95.39% 95.23% -0.17%
==========================================
Files 62 64 +2
Lines 8021 8344 +323
Branches 1035 1077 +42
==========================================
+ Hits 7652 7946 +294
- Misses 266 284 +18
- Partials 103 114 +11
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It is in nixpkgs as an "application" but we can derive a regular Python package from that.
Before they got the anonymous storage service fURL and skipped all of our ZKAP-related codepaths. There was some code to try to give client nodes the correct servers.yaml content but it ran in TahoeNode.create and then got clobbered by the code in TahoeClient.create. Huzzah, inheritance.
Our fancy JSON type is not _that_ fancy so this is still wrong, but maybe less aggressively so...
macOS seems to need two ticks. This mirrors another copy of this pattern in fixtures.py.
Collaborator
Author
|
Coverage reporting is broken but CI is otherwise green. I'm satisfied that the new integration tests are exercising what they should now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix all of the storage protocol integration methods.
Fixes #433