Skip to content

fix: remove Firefox automatic playback fallback #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priveetee merged 1 commit into from
Apr 24, 2026
Merged

fix: remove Firefox automatic playback fallback #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions apps/web/src/hooks/use-player-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,11 @@ function hasMultipleAudioLanguages(stream: VideoStream): boolean {
return false;
}

function isFirefoxBrowser(): boolean {
if (typeof navigator === "undefined") return false;
return navigator.userAgent.includes("Firefox/");
}

export function usePlayerError(stream: VideoStream, isLive: boolean): UsePlayerErrorReturn {
const streamId = stream.id;
const debugVideo = sanitizeVideoContext(streamId) ?? "unknown";
const preferNativeManifest = !isIosDevice() && !hasMultipleAudioLanguages(stream);
const nativeEnabled =
!isLive &&
!isFirefoxBrowser() &&
Boolean(stream.videoOnlyStreams?.length) &&
preferNativeManifest;
const nativeEnabled = !isLive && Boolean(stream.videoOnlyStreams?.length) && preferNativeManifest;
const [nativeFailed, setNativeFailed] = useState(false);
const [qualityFailed, setQualityFailed] = useState(false);
const [compatibilityFallback, setCompatibilityFallback] = useState(false);
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/lib/stream-src.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export function resolveManifestSrc(
};
}

if (!isLive && (compatibilityMode || isFirefox)) {
if (!isLive && compatibilityMode) {
const progressiveSrc = pickCompatibleProgressiveSrc(stream);
if (progressiveSrc) return progressiveSrc;
}
Expand Down