Skip to content

Fix duplicate content in floating event card after swipe navigation#63

Merged
ProLoser merged 2 commits intomainfrom
copilot/fix-duplicate-details-rendering
Mar 18, 2026
Merged

Fix duplicate content in floating event card after swipe navigation#63
ProLoser merged 2 commits intomainfrom
copilot/fix-duplicate-details-rendering

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

After swiping between events, tapping any marker rendered duplicate overlapping content in the card — resolved only by swiping again.

Root Cause

#event-card-peek is position: absolute; top: 0; left: 0, so clearing its inline transform leaves it sitting directly on top of #event-card-current. finishNavigation was doing exactly that after every swipe, leaving stale event content visible over whatever showEventCard rendered next.

// Before — removes inline style; peek falls back to default position (overlaps current)
peek.style.transform = '';

// After — explicitly moves peek off-screen
peek.style.transform = 'translateX(100%)';

Changes

  • finishNavigation: replace peek.style.transform = '' with translateX(100%) so peek is always off-screen after a swipe completes
  • showEventCard: apply the same reset so any residual peek position is cleared when opening a card fresh

Before / After

Before After
duplicate fixed
Original prompt

tapping an event is rendering duplicate details in the card initially that's fixed by swiping to a different event


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@ProLoser
Copy link
Copy Markdown
Owner

@copilot Screenshot_20260317-162725.png

Here is a screenshot of the bug

Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix duplicate details rendering on event tap Fix duplicate content in floating event card after swipe navigation Mar 17, 2026
Copilot AI requested a review from ProLoser March 17, 2026 23:35
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 17, 2026

@copilot Screenshot_20260317-162725.png

...

That screenshot confirms exactly the root cause identified — #event-card-peek (position: absolute; top:0; left:0) was left at its default position after a swipe, overlapping #event-card-current with the previous event's content.

This is addressed in commit 1674c82:

  • finishNavigation: peek.style.transform = ''peek.style.transform = 'translateX(100%)'
  • showEventCard: added the same reset so any residual peek position is cleared on fresh card open
Before After
before after

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-18 00:10 UTC

@ProLoser ProLoser marked this pull request as ready for review March 18, 2026 00:08
@ProLoser ProLoser merged commit 8c31c98 into main Mar 18, 2026
2 checks passed
@ProLoser ProLoser deleted the copilot/fix-duplicate-details-rendering branch March 18, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants