chore: relax scaffold .vscode policy and bump to 0.7.1#97
Merged
Conversation
Three small follow-ups on top of the VSCode recommendations work: - .gitignore: drop the `.vscode/*` + negation block. The team has decided to track the whole `.vscode/` directory (launch.json, tasks.json, etc.) instead of pinning just extensions.json / settings.json. Personal preference files can still be locally ignored via `.git/info/exclude` if needed. - .vscode/settings.json: drop `python.analysis.typeCheckingMode` and `python.analysis.extraPaths`. Both are already governed by `[tool.pyright]` in pyproject.toml; duplicating them in the workspace settings invited drift. - Bump act-operator 0.7.0 → 0.7.1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version to 0.7.1 and modifies the VS Code configuration and .gitignore in the scaffold directory. The reviewer recommends retaining the .vscode/ ignore rules in .gitignore while whitelisting specific shared files to prevent developers from accidentally committing local VS Code settings.
I am having trouble creating individual review comments. Click here to see my feedback.
act_operator/act_operator/scaffold/{{ cookiecutter.act_slug }}/.gitignore (123-125)
.vscode/ 디렉토리 전체를 Git 추적 대상으로 설정하면, 개발자 개인의 로컬 설정(예: launch.json 내의 개인화된 경로, tasks.json 내의 로컬 명령어, 혹은 다른 VS Code 확장 프로그램이 생성하는 임시 파일 등)이 실수로 커밋될 위험이 큽니다.
모든 개발자가 .git/info/exclude를 수동으로 설정하도록 유도하는 것은 실수하기 쉽고 개발자 경험(DX) 측면에서도 번거로울 수 있습니다.
대신, 팀원들과 공유가 필요한 특정 설정 파일만 명시적으로 허용(whitelist)하는 방식을 권장합니다. 예를 들어 launch.json이나 tasks.json도 공유하고 싶다면 아래와 같이 해당 파일들만 예외로 추가하는 것이 안전합니다.
.vscode/*
!.vscode/extensions.json
!.vscode/settings.json
!.vscode/launch.json
!.vscode/tasks.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 PR Type
📝 Summary
PR #95 후속 정리 + patch 버전 bump.
📄 Description
1.
.gitignore—.vscode/전체 추적으로 정책 완화PR #95에서 도입한 패턴:
→ 삭제.
.vscode/디렉토리 전체를 추적 대상으로 변경 (launch.json, tasks.json 등 팀 공유 가능). 개인 환경 preference는.git/info/exclude로컬 ignore로 처리.2.
.vscode/settings.json— pyright 중복 제거두 항목은 이미
pyproject.toml의[tool.pyright]가 관할 — workspace settings에서 중복 명시 시 drift 가능. single source of truth로 통일.3. 버전 bump
act_operator/__init__.py:0.7.0→0.7.1(patch).pyproject.toml이[tool.hatch.version]로 이 파일을 source-of-truth로 참조하므로 빌드 시 자동 반영.✅ Quality Checks
🤖 Generated with Claude Code