fix: update platzky dependency #333

raven-wing · 2026-02-12T02:20:22Z

Summary by CodeRabbit

New Features
- Extended configuration validation to accept additional validation options.
Bug Fixes / Improvements
- Improved clarity of JSON payload size error message.
- Minor sorting/pagination formatting change with no behavioral impact.
Chores
- Removed an unused dependency and updated two dependencies.
- CI workflow reference updated.
Tests
- Small test formatting cleanup.

coderabbitai · 2026-02-12T02:20:38Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Removed Flask from dependencies, bumped pydantic and platzky versions, updated CI workflow commit reference, extended Goodmap.model_validate signature, adjusted sorting type-ignore placement, reformatted a JSON error message, and applied a minor test formatting change.

Changes

Cohort / File(s)	Summary
Dependency manifest `pyproject.toml`	Removed public dependency `Flask = "3.0.3"`; upgraded `pydantic` `^2.7.1` → `^2.12.0` and `platzky` `^1.4.1` → `^1.4.6`.
CI workflow ref `.github/workflows/tests.yml`	Updated referenced e2e-tests workflow commit hash to `a48cdaedbeed0a38d4852ffc973e52477114ae9e` (reference bump only).
Goodmap config API `goodmap/config.py`	Added `Literal` import and extended `GoodmapConfig.model_validate(...)` signature to accept `by_alias`, `by_name`, and `extra`, forwarding them to `super().model_validate(...)`.
Goodmap minor edits `goodmap/db.py`, `goodmap/json_security.py`	`db.py`: moved type-ignore annotation off the lambda line and reformatted sort call arguments (no behavioral change). `json_security.py`: combined JSON size error text into a single formatted string (formatting only).
Tests formatting `tests/unit_tests/test_core.py`	Whitespace/formatting change in f-string from `f"PCK_{i+1}"` to `f"PCK_{i + 1}"` — no behavior change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: more docs introduced #332 — touches the same PaginationHelper sorting implementation modified here.
fix: updated dependencies (/health/readines|liveness checks added #260 — also updates the project's platzky dependency version.

"I hopped through lines with carrot cheer,
Removed a Flask and bumped things near,
I stretched a sig and fixed a string,
Quiet hops make small code sing,
A joyful nibble, coders, here!" 🐇✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title focuses on updating the platzky dependency, but the PR includes multiple significant changes: dependency updates (pydantic, platzky), workflow reference updates, signature extensions in config.py, formatting adjustments, and error message refinements across multiple files.	Revise the title to reflect the scope of changes more accurately, such as 'fix: update dependencies and extend GoodmapConfig validation' or 'fix: dependency updates and API signature extensions'.
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-12T02:32:46Z

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: e75660c

⚠️ E2E Stress Test Results

Performance data not found. See workflow logs for details.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@goodmap/config.py`:
- Around line 26-41: The project requires Pydantic features (by_name and
by_alias parameters used in GoodmapConfig.model_validate) that were added in
v2.11; update the pyproject.toml pydantic version constraint from "^2.7.1" to
"^2.11.0" (and then run your dependency manager to regenerate the lockfile) so
GoodmapConfig.model_validate, and its use of by_alias/by_name, will be supported
at install time.

goodmap/config.py

github-actions · 2026-02-12T03:02:46Z

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: f79b8c5

⚠️ E2E Stress Test Results

Performance data not found. See workflow logs for details.

github-actions · 2026-02-12T04:16:58Z

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: 09c6c75

⚠️ E2E Stress Test Results

Performance data not found. See workflow logs for details.

github-actions · 2026-02-12T04:49:29Z

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: 8d153b2

📊 E2E Stress Test Performance

✅ Status: PASSED (10765.68ms max < 25000ms limit)

Metric	Value
Average Time	9995.23ms
Minimum Time	9684.25ms
Maximum Time	10765.68ms
Completed Runs	5/5
Avg Markers Loaded	71

📈 Individual Run Times

Run	Time (ms)	Markers
Run 1	10089.39ms	71
Run 2	9704.88ms	71
Run 3	10765.68ms	71
Run 4	9731.93ms	71
Run 5	9684.25ms	71

sonarqubecloud · 2026-02-12T10:28:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pyproject.toml`:
- Around line 21-22: Update the dependency versions in pyproject.toml: change
the nonexistent platzky version "1.4.6" to a published release (e.g., "1.0.1")
and adjust the pydantic spec to a safe, compatible release (either bump to
">=2.12.3" to avoid classmethod validator errors or pin to "^2.11.x" if your
code relies on prior behavior); then run tests and search for usages of pydantic
model validators/serialize_as_any to ensure no implicit classmethod validators
or serialization assumptions break (look for references to "pydantic" and any
model validator definitions).

pyproject.toml

github-actions · 2026-02-12T10:30:49Z

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: 826a3fe

📊 E2E Stress Test Performance

✅ Status: PASSED (10520.06ms max < 25000ms limit)

Metric	Value
Average Time	10365.48ms
Minimum Time	10158.11ms
Maximum Time	10520.06ms
Completed Runs	5/5
Avg Markers Loaded	71

📈 Individual Run Times

Run	Time (ms)	Markers
Run 1	10342.54ms	71
Run 2	10520.06ms	71
Run 3	10488.41ms	71
Run 4	10158.11ms	71
Run 5	10318.27ms	71

chore: update platzky dependency

95b84a5

raven-wing added 3 commits February 12, 2026 03:21

fix

02ec7b7

lint fixes

c20cef2

fixes of linting

e75660c

updated to new test

f79b8c5

coderabbitai bot reviewed Feb 12, 2026

View reviewed changes

goodmap/config.py Show resolved Hide resolved

update goodmap

09c6c75

updated e2e test dep

8d153b2

fix after review

826a3fe

coderabbitai bot reviewed Feb 12, 2026

View reviewed changes

pyproject.toml Show resolved Hide resolved

raven-wing merged commit 1714928 into Problematy:main Feb 12, 2026
6 checks passed

raven-wing deleted the new_platzky branch February 12, 2026 10:46

coderabbitai bot mentioned this pull request Feb 12, 2026

chore: add python 3.14 test matrix and update dependencies #334

Merged

fix: update platzky dependency #333

fix: update platzky dependency #333

Uh oh!

Conversation

raven-wing commented Feb 12, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

github-actions bot commented Feb 12, 2026

🧪 E2E Test Results

⚠️ E2E Stress Test Results

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

🧪 E2E Test Results

⚠️ E2E Stress Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

🧪 E2E Test Results

⚠️ E2E Stress Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

🧪 E2E Test Results

📊 E2E Stress Test Performance

Uh oh!

sonarqubecloud bot commented Feb 12, 2026

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

🧪 E2E Test Results

📊 E2E Stress Test Performance

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

raven-wing commented Feb 12, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 12, 2026 •

edited

Loading