Skip to content

Conversation

@julceslauhub
Copy link
Contributor

@julceslauhub julceslauhub commented Mar 9, 2023

Required PRs

Issue & Reproduction Steps

The blade templates uses the helper "shouldShow" in order to display or hide the sections that be can configurable

Solution

  • Added new helper "shouldShow"
  • The helper is safe, if the package "dynamic-uid" is not installed and the visibility settings are not present in session, the sections are always displayed

How to Test

Is required test with and without de package "dynamic-ui" installed, if is not installed all sections should be displayed normally. If the package is installed, the administrator can be hide some sections for a group in the profile's group page.

The changes only be applied the next time that the users assigned to the group login to the app.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:package-dynamic-ui:feature/FOUR-6105

.

… UI so that my custom solution can feel and operate distinctly from ProcessMaker’s standard functionality
@julceslauhub julceslauhub requested a review from nolanpro March 10, 2023 18:31
@julceslauhub julceslauhub force-pushed the feature/FOUR-6105 branch 2 times, most recently from c2c0c65 to 484bb57 Compare March 20, 2023 15:30
@pmkerberos
Copy link

QA server was successfully deployed https://ci-d70019f126.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

QA server was successfully deployed https://ci-d70019f126.eng.processmaker.net

# Conflicts:
#	resources/views/layouts/navbar.blade.php
@ryancooley ryancooley merged commit 8a10a51 into develop Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants