-
Notifications
You must be signed in to change notification settings - Fork 243
FOUR-7637 | Ellipsis Menu #4642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
estebangallego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mcraeteisha I noticed that the View Documentation button is been shown without the package installed.

estebangallego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Also remove reference to Templates; remove dropdown offset
|
Looks good! |
| class="pr-1" | ||
| :class="`${action.icon} fa-fw`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding fa-fw to the class line instead of the :class line so we don't have to do the interpolation on the :class line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Description
Ticket: FOUR-7637
Create a new, reusable dropdown menu component used to house actions/links.
How to Test
feature/FOUR-7637.Current UI
Updated UI
Related Tickets & Packages
Code Review Checklist