Skip to content

Conversation

@mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Mar 16, 2023

Description

Ticket: FOUR-7637

Create a new, reusable dropdown menu component used to house actions/links.

How to Test

  1. Go to branch feature/FOUR-7637.
  2. View updated actions in Processes Listing.

Current UI

Screen_Shot_2023-03-16_at_12_42_14_PM

Updated UI

Screen_Shot_2023-03-16_at_12_45_00_PM

Screen_Shot_2023-03-16_at_17_23_39_PM

Screen_Shot_2023-03-16_at_17_21_03_PM

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@estebangallego estebangallego self-requested a review March 17, 2023 19:31
Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mcraeteisha I noticed that the View Documentation button is been shown without the package installed.
Screenshot 2023-03-17 at 3 41 12 PM

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mcraeteisha mcraeteisha requested a review from ryancooley April 3, 2023 19:23
@mcraeteisha mcraeteisha requested a review from agustinbusso April 5, 2023 14:52
@hvanlear
Copy link

hvanlear commented Apr 6, 2023

Looks good!

@ryancooley ryancooley requested a review from hvanlear April 6, 2023 17:58
Comment on lines 28 to 29
class="pr-1"
:class="`${action.icon} fa-fw`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend adding fa-fw to the class line instead of the :class line so we don't have to do the interpolation on the :class line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@ryancooley ryancooley merged commit 8169e4d into develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants