-
Notifications
You must be signed in to change notification settings - Fork 243
Process Templates: Add Process Templates Permissions #4643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now TemplateSearch
…rocessmaker into feature/FOUR-7377
…rocessmaker into feature/FOUR-7376
…Template and TemplateCategory models
…rocessmaker into feature/FOUR-7377
…tTemplates variable
mcraeteisha
approved these changes
Mar 22, 2023
Contributor
mcraeteisha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! A user can define permissions for templates, and permissions behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Ticket: FOUR-7566
As part of Process Templates EPIC FOUR-7375, a Master Builder should be able to define permissions for who can view, edit, delete, import, export templates.
Note: The current state of Process Templates only allows for 'view', 'edit' - in regards to updating the template name/description, and 'export'. Other functionality for 'edit' - editing the template in modeler, and 'import' will be added in another ticket.
Solution
$typeparameter to handle xx template permissions.How to Test
Test A:
Template options do not appear when user has no process template permissions
php artisan migrateExpected Behavior
Test B:
The correct template options appear when the associated permission is enabled for the user
Related Tickets & Packages
Code Review Checklist