Skip to content

Import/Export updates for dependent select list #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryancooley merged 2 commits into from
Apr 11, 2023
Merged

Import/Export updates for dependent select list #4659

ryancooley merged 2 commits into from
Apr 11, 2023

Conversation

@nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Mar 31, 2023 •
edited
Loading

Requires the following PRs

Issue & Reproduction Steps

Import/Export modifications needed for collections select list

Solution

  • Modify screen exporter

How to Test

  • Export a process with a screen that has a collection select list

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:screen-builder:feature/FOUR-7437
ci:vue-form-elements:feature/FOUR-7437
ci:package-collections:feature/FOUR-7437
ci:package-webentry:feature/FOUR-7437
......

@github-actions github-actions bot added the codeball:approved Codeball label Mar 31, 2023
github-actions[bot]
github-actions bot previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.97 | [dashboard]

@nolanpro nolanpro changed the title Update findScreenDependent to get nested components Import/Export updates for dependent select list Mar 31, 2023
@pmkerberos
Copy link

pmkerberos commented Mar 31, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

4 similar comments
@pmkerberos
Copy link

pmkerberos commented Mar 31, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@github-actions github-actions bot added codeball:needs-review Codeball and removed codeball:approved Codeball labels Apr 7, 2023
@github-actions github-actions bot dismissed their stale review April 7, 2023 17:42

confidence: 0.84 | [dashboard]

@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Apr 7, 2023

QA server was successfully deployed Could not open input file: deploy-stm/get-url.php

This was referenced Apr 10, 2023
Merged
Merged
@pmkerberos
Copy link

pmkerberos commented Apr 10, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@nolanpro nolanpro requested a review from julceslauhub April 10, 2023 18:02
@pmkerberos
Copy link

pmkerberos commented Apr 10, 2023

QA server was successfully deployed https://ci-ddab00c6f8.eng.processmaker.net

@ryancooley ryancooley merged commit 9dff375 into develop Apr 11, 2023
julceslauhub
julceslauhub reviewed Apr 11, 2023
View reviewed changes
tests/Feature/ImportExport/UtilsTest.php

public function testFindScreenDependent()
{
$config = [
Copy link
Contributor

@julceslauhub julceslauhub Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this item can be a json in the "fixtures" folder

Copy link
Contributor Author

@nolanpro nolanpro Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, fixed

julceslauhub
julceslauhub reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julceslauhub julceslauhub julceslauhub left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

codeball:needs-review Codeball

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nolanpro @pmkerberos @julceslauhub @ryancooley