Skip to content

Conversation

@sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Apr 11, 2023

Issue & Reproduction Steps

Ticket: FOUR-7912

The current implementation of the default templates does not display the initials of a user in the author avatar, as no user is associated with the default templates since they are system templates. As a result, the author avatar is not displayed.

Solution

To resolve this issue, we removed the author avatar when no user is associated with the default templates. Once a user edits a default template, they will be automatically assigned as the author of the template, and their initials will be displayed in the author avatar.

How to Test

Verify that the author avatar is not displayed for the default templates that have not been edited by any user.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@github-actions github-actions bot added the codeball:approved Codeball label Apr 11, 2023
github-actions[bot]
github-actions bot previously approved these changes Apr 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.96 | [dashboard]

@github-actions github-actions bot dismissed their stale review April 11, 2023 23:25

confidence: 0.23 | [dashboard]

@pmkerberos
Copy link

QA server was successfully deployed https://ci-6c5df126e1.eng.processmaker.net

@sanjacornelius sanjacornelius merged commit 2cd987d into feature/FOUR-7375-b Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants