-
Notifications
You must be signed in to change notification settings - Fork 243
Integrate Ellipses Menu pt1 #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebangallego
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Ticket FOUR-8029
Solution
Implements the new ellipsis menu in the following areas:
How to Test
Ensure you have the Dyanmic UI Package installed using branch
task/FOUR-8029Check that all areas listed above have the new Ellipsis menu properly configured based on the actions available for each one. This means that the menu should display all relevant options and functions, and that any unnecessary items are removed from the dropdown menu.
Ensure that permissions are correctly supported. Users with appropriate permissions should be able to access and use the menu, while users without those permissions should not be able to see or interact with it.
Test that selecting actions from the menu that do not open a modal or run a function is a proper link. These links should be able to be opened in a new tab by selecting the "command" or "ctrl" key on your keyboard while clicking on the link.
Related Tickets & Packages
- Dynamic UI Package PR
Code Review Checklist