Skip to content

Conversation

@ryancooley
Copy link
Contributor

@ryancooley ryancooley commented Apr 20, 2023

Issue & Reproduction Steps

Steps to Reproduce

  1. Run npm run prod or npm run dev on a clean install with no custom CSS colors, ensuring that it runs as expected
  2. Visit /admin/customize-ui
  3. Change some of the default colors and click save, allowing the CSS to regenerate
  4. Run npm run prod or npm run dev again

Current Behavior

The build fails with the following error:

SassError: Undefined variable.
  ╷
6 │   color: $darkneutral;
  │          ^^^^^^^^^^^^

Expected Behavior

The build should complete without error.

Solution

  • Removed the color variables that were added to support the new Import/Export functionality from the _colors.scss file and moved them to the _variables.scss file. Since the Customize UI functionality was replacing the _colors.scss file without those new colors in it, the build would fail. Now, those color variables exist regardless of the status of the _colors.scss file, so the build runs as expected.
  • During testing it was also discovered that the default colors presented on the Customize UI page were based on the old default colors which have since changed. So those were updated as well.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@ryancooley ryancooley requested a review from agustinbusso April 20, 2023 01:14
@ryancooley ryancooley changed the base branch from develop to 4.5.1-develop April 20, 2023 03:46
Copy link
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could compile after the changes. Colors of the new version are correctly applied after using "reset" functionality

@ryancooley ryancooley merged commit 49bdb05 into 4.5.1-develop Apr 20, 2023
ryancooley added a commit that referenced this pull request Apr 24, 2023
[FOUR-8126] Recompiling Mix fails on instance when colors have been customized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants