-
Notifications
You must be signed in to change notification settings - Fork 243
Bugfix/FOUR-6473: As a process designer, I want to be able to index fields in JSON data #4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/FOUR-8051
paulosakamoto
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Note: Mysql 8 required
Please read description at: https://processmaker.atlassian.net/browse/FOUR-6473
Related Tickets & Packages
Testing Notes
bigText(string),numberValue(integer between 1 and 1000),stringNumberValue(same number but as a string), andrandomString(10 characters)Testing plan
data.stringNumberValue = "950", another saved search withdata.numberValue = "123"etc.php artisan upgradeand make sure the indexes for referenced json columns were created.data.randomString = "X6YXefgktF". Make sure that index is created (new index creation is a queued job)Example query that should return 429 quickly after the indexes have been added
Limitations
data.numberValue = "123"and it will use the index>,<will not use indexescount(*)is still slow to get all rows and is a limitation of mysqllikewill not use the index and will be slow