Skip to content

Fix url matchers for loading screen#4743

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-8444
May 5, 2023
Merged

Fix url matchers for loading screen#4743
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-8444

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro commented May 4, 2023

Issue & Reproduction Steps

See Jira ticket

Solution

  • The URL matchers for the shared data loading component were incorrect. This fixes them.

How to Test

Follow steps in Jira ticket.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

..

@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-054ca75eaf.eng.processmaker.net

3 similar comments
@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-054ca75eaf.eng.processmaker.net

@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-054ca75eaf.eng.processmaker.net

@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-054ca75eaf.eng.processmaker.net

@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-054ca75eaf.eng.processmaker.net

@danloa
Copy link
Copy Markdown
Contributor

danloa commented May 5, 2023

When using Slow 3G throttling and sending many API calls (such as when switching tabs), some API calls may get canceled. However, with the fix of this PR in place, the API error message is removed after the last call succeeds."

image
After a while:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants