Skip to content

FOUR-8231 #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmPaulis merged 20 commits into from
May 26, 2023
Merged

FOUR-8231 #4785

pmPaulis merged 20 commits into from
May 26, 2023

Conversation

@luNunezProcessmaker
Copy link
Contributor

@luNunezProcessmaker luNunezProcessmaker commented May 15, 2023 •
edited
Loading

Issue & Reproduction Steps

N/A

Solution

N/A

How to Test

  • Go to admin
  • Select edit an user
  • Go to groups tab
  • Change the groups and SAVE
  • Check the security_logs table for a new log "groupMembershipChanged"

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-8231

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@luNunezProcessmaker luNunezProcessmaker force-pushed the feature/FOUR-8231 branch 3 times, most recently from 9984c6f to a769912 Compare May 18, 2023 19:34
@pmkerberos
Copy link

pmkerberos commented May 19, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

pmPaulis
pmPaulis requested changes May 22, 2023
View reviewed changes
paulosakamoto
paulosakamoto reviewed May 22, 2023
View reviewed changes
paulosakamoto
paulosakamoto reviewed May 22, 2023
View reviewed changes
paulosakamoto
paulosakamoto reviewed May 24, 2023
View reviewed changes
@pmkerberos
Copy link

pmkerberos commented May 24, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

pmPaulis
pmPaulis requested changes May 25, 2023
View reviewed changes
@pmPaulis pmPaulis changed the title feature/FOUR-8231 FOUR-8231 May 25, 2023
@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

pmPaulis
pmPaulis approved these changes May 25, 2023
View reviewed changes
@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

2 similar comments
@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented May 25, 2023

QA server was successfully deployed https://ci-3895896475.eng.processmaker.net

@pmPaulis pmPaulis merged commit 8909648 into feature/FOUR-8121 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmPaulis pmPaulis pmPaulis approved these changes

@fagubla fagubla Awaiting requested review from fagubla

+1 more reviewer

@paulosakamoto paulosakamoto paulosakamoto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

codeball:needs-careful-review Codeball

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luNunezProcessmaker @pmkerberos @paulosakamoto @pmPaulis