Skip to content

Conversation

@eiresendez
Copy link
Contributor

@eiresendez eiresendez commented May 16, 2023

Issue & Reproduction Steps

As a user, I want to visualize the process map on the Process Request Page (Overview tab) to understand the context of my task.

  1. Create a Process with multiple tasks
  2. Run a new Request.
  3. Go to /requests/{id} page and click the "Overview" tab.

You should be able to see the Process Map.

Solution

  • Created a new route process.inflight to display a minified version of Modeler. It was simpler and safer to create a new layout, views, and resources for this use case.
    • The BPMN version is obtained based on the current request.
    • This version only displays the paper and removes sidebars, navbars, inspector, toolbar, and all related components.
    • The new component is called ModelerReadonly (see Modeler's PR).
  • Formatting changes were applied using ESLint and PHP CS Fixer.

Working video:

Screen.Recording.2023-05-24.at.3.25.11.p.m.mov

How to Test

  • Follow the reproduction steps of above.
  • Link Modeler and Core or test using the deployed QA Server.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:modeler:feature/FOUR-8527
ci:deploy

@eiresendez eiresendez requested a review from gustavobascope May 17, 2023 18:50
@eiresendez eiresendez marked this pull request as ready for review May 17, 2023 18:50
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the process model is too large the overview cut it
Screenshot from 2023-05-18 12-22-04

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@eiresendez eiresendez requested a review from gustavobascope May 18, 2023 18:20
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The observation was fixed

image

@eiresendez eiresendez requested a review from nolanpro May 18, 2023 19:35
@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

2 similar comments
@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ci-e77ed785c9.eng.processmaker.net

@nolanpro nolanpro merged commit 01861bb into FOUR-8000 May 31, 2023
@nolanpro nolanpro mentioned this pull request May 31, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants