Skip to content

Conversation

@mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented May 18, 2023

Issue

Ticket: FOUR-8608

In the Forms tab of the Request details, the Photo/Video control is live. The camera is on and you are able to record a video or take a picture.

Solution

Remove the Photo/Video control when in the Forms tab, similarly to how the File Upload control is removed.

Steps to Reproduce

  1. Log in to ProcessMaker.
  2. Create a new Screen with a Photo/Video control. Configure the Control.
  3. Add the Screen to a Process and start a new Request of the Process.
  4. Complete the Process, open the Request, and go to the Forms tab.

How to Test

  1. Go to branch observation/FOUR-8608 in core.
  2. Install package-photo-video.
  3. Follow the Steps to Reproduce.
  4. The Photo/Video control should not show in the Forms tab of the Request details.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@github-actions github-actions bot added the codeball:approved Codeball label May 18, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.96 | [dashboard]

@ryancooley ryancooley merged commit 90f1dbc into develop Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants