Skip to content

Conversation

@agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented May 23, 2023

Issue & Reproduction Steps

Steps to Reproduce:

  • Go to Admin / settings
  • Configure 2 custom email servers (Email server 1 and Email server 2)
  • Create a process and add a connector send email
  • Configure the connector server to point to the first server (not the default server)
  • Export the process
  • Go to Admin / settings again
  • Delete the Email server 1
  • Try to import the exported process

Current Behavior:
An error is displayed: Email server does not exists, index 1 and the importing process is stopped

Expected Behavior:
The importing process should continue. If the email sever configured in the connector send email does not exists in the new instance, assign the default server for the connector and show a message to the user.

Solution

  • Do not throw an exception when the email server not found while importing. Assign the default server instead and show a message.

Working video

Screen.Recording.2023-05-23.at.11.58.36.mov

How to Test

  • Follow steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@agustinbusso agustinbusso marked this pull request as ready for review May 23, 2023 17:42
@eiresendez eiresendez self-requested a review May 29, 2023 18:59
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! The import does not stop when the email server doesn't exist

Screen Shot 2023-05-29 at 12 25 05 p m

@ryancooley ryancooley merged commit 114a482 into develop May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants