Skip to content

Conversation

@caleeli
Copy link
Contributor

@caleeli caleeli commented May 31, 2023

Implement a Kafka Drive for PM4 Core

How to Test

  • Bring up consumer: php artisan processmaker:consumer

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@caleeli caleeli requested a review from julceslauhub May 31, 2023 14:08
private function dispatchAction(array $action): void
{
$subject = $action['action'];
$subject = 'requests';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change can broke the flow that is working now...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consumers at Nayra are now listening the subject (queue | topic) requests, it will work

@caleeli caleeli requested a review from julceslauhub June 1, 2023 19:06
@caleeli caleeli marked this pull request as ready for review June 1, 2023 19:06
Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)

@caleeli caleeli merged commit 011cdf1 into FOUR-8177 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants