FOUR-8552 Refactor completeTask function to use Nayra BPMN engine (RabbitMQ) #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleeli
reviewed
May 31, 2023
| // Update the request | ||
| $properties = $transaction['properties']; | ||
| $model = ProcessRequest::find($id); | ||
| $model = ProcessRequest::find($transaction['id']); |
Contributor
There was a problem hiding this comment.
Is this right? $transaction['id'] must be the uuid of the request, not the id
Contributor
Author
There was a problem hiding this comment.
this is correct, the message returned by Nayra only have numeric ids
caleeli
reviewed
May 31, 2023
| // Update the request token | ||
| $properties = $transaction['properties']; | ||
| $model = ProcessRequestToken::find($id); | ||
| $model = ProcessRequestToken::find($transaction['id']); |
Contributor
There was a problem hiding this comment.
Is this right? $transaction['id'] must be the uuid of the request token, not the id.
Are we going to use id for updates?
Take in count that the engine could create new token and that will have an uuid in Nayra side...
Contributor
|
@julceslauhub as discused in the meeting please review this scenario that includes a parallel task and a boundary event.
|
…bbitMQ) - Fix David's observations
caleeli
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
The WorkflowManage::completeTask function currently performs various actions within the method itself. This ticket aims to refactor the function to use the Nayra BPMN engine for executing the task. The function should be modified to invoke the appropriate Nayra Engine services and events to complete the task.
Solution
How to Test
Use the message broker drive "rabbitmq", bring up consumer: php artisan processmaker:consumer, create a request and complete the same.
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-8177
Code Review Checklist