Skip to content

Resolving Excessive Fetch Calls Triggered on Requests & Tasks Pages#4853

Merged
ryancooley merged 2 commits into
developfrom
feature/FOUR-8814
Jun 23, 2023
Merged

Resolving Excessive Fetch Calls Triggered on Requests & Tasks Pages#4853
ryancooley merged 2 commits into
developfrom
feature/FOUR-8814

Conversation

@sanjacornelius
Copy link
Copy Markdown
Contributor

@sanjacornelius sanjacornelius commented Jun 5, 2023

Issue & Reproduction Steps

When loading the Requests & Tasks pages, the endpoint {{SERVER}}/api/1.0/requests?page=1&per_page=10&include=process,participants,data&pmql=(status%20%3D%20%22In%20Progress%22)%20AND%20(requester%20%3D%20%22admin%22)&filter=&order_by=id&order_direction=DESC is being loaded three times instead of the expected two times. This issue is caused by the new PMQL component triggering the fetch method three times.

Solution

To resolve this issue, we need to remove the excessive emit in the mounted method that triggers the fetch method. This will ensure that the endpoint is only triggered twice, as intended.

How to Test

  1. Open the Browser’s DevTool
  2. Open PM (or Go to Requests or Tasks page)

Expected Behavior

The above endpoint is triggered only twice.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-aadc2b76a2.eng.processmaker.net

@ryancooley ryancooley merged commit 0e943f2 into develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants