Skip to content

FOUR-8284: Create a Helper to compare two arrays #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmPaulis merged 4 commits into from
Jun 22, 2023
Merged

FOUR-8284: Create a Helper to compare two arrays #4901

pmPaulis merged 4 commits into from
Jun 22, 2023

Conversation

@CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Jun 19, 2023

Issue & Reproduction Steps

Create a Helper to compare two arrays changes vs origin.
Event UserUpdate was changed to avoid keys from Package in User Information package-advanced-user-manager

ArrayHelper
UserUpdated

The Helper has 2 methods:
stdClassToArray
getArrayDifferencesWithFormat

Related Tickets & Packages

  • FOUR-8284

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@pmkerberos
Copy link

pmkerberos commented Jun 19, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

3 similar comments
@pmkerberos
Copy link

pmkerberos commented Jun 19, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Jun 19, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Jun 19, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

pmPaulis
pmPaulis requested changes Jun 19, 2023
View reviewed changes
pmPaulis
pmPaulis requested changes Jun 20, 2023
View reviewed changes
@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

luNunezProcessmaker
luNunezProcessmaker reviewed Jun 20, 2023
View reviewed changes
@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

pmPaulis
pmPaulis requested changes Jun 20, 2023
View reviewed changes
@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Jun 20, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmPaulis pmPaulis changed the title Feature/four 8284 FOUR-8284: Create a Helper to compare two arrays Jun 21, 2023
@pmkerberos
Copy link

pmkerberos commented Jun 21, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmkerberos
Copy link

pmkerberos commented Jun 22, 2023

QA server was successfully deployed https://ci-2d5878ba0e.eng.processmaker.net

@pmPaulis pmPaulis merged commit 44962c9 into feature/FOUR-8121 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmPaulis pmPaulis pmPaulis approved these changes

+1 more reviewer

@luNunezProcessmaker luNunezProcessmaker luNunezProcessmaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CarliPinell @pmkerberos @pmPaulis @luNunezProcessmaker