Skip to content

Bugfix/FOUR-9016:#4914

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9016
Jun 23, 2023
Merged

Bugfix/FOUR-9016:#4914
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9016

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Jun 22, 2023

Issue & Reproduction Steps

Steps to Reproduce:

  • Import the attached process and be sure you don’t have a screen with id 25 in your instance
  • Go to process > configure

Steps_test.json.zip

Solution

  • Replace findOrFail with find. Verify screen exists. Added a check also for the key content in select lists

How to Test

Follow steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@agustinbusso agustinbusso requested a review from nolanpro June 22, 2023 19:07
@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-83b27e0bd3.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-83b27e0bd3.eng.processmaker.net

@ryancooley ryancooley merged commit 48026ae into develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants