Skip to content

FOUR-8559 Refactor throwMessageEvent function to use Nayra BPMN engine#4920

Merged
caleeli merged 6 commits into
FOUR-8177from
FOUR-8559
Jun 28, 2023
Merged

FOUR-8559 Refactor throwMessageEvent function to use Nayra BPMN engine#4920
caleeli merged 6 commits into
FOUR-8177from
FOUR-8559

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Jun 23, 2023

This PR refactors the throwMessageEvent function. The primary objective was to enhance the function's performance and provide it the capability to trigger a BpmnAction message event using instance ID, element ID, message reference, and an optional payload. This is important to improve the Webhook Callback in our package-data-sources.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@caleeli caleeli requested a review from julceslauhub June 23, 2023 18:18
@caleeli caleeli changed the base branch from develop to FOUR-8177 June 23, 2023 18:21
@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-6e88847f56.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link
Copy Markdown

QA server was successfully deployed https://ci-6e88847f56.eng.processmaker.net


// Get complementary information
$version = $definitions->getLatestVersion();
$version = $instance->process_version_id;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change the line: 'bpmn' => $version->getKey(), to 'bpmn' => $version,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed.

Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@caleeli caleeli merged commit cfda7de into FOUR-8177 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants